-
Notifications
You must be signed in to change notification settings - Fork 4
Add git-conceal-unlock wrapper
#195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d3483a to
e79b4e5
Compare
|
I believe the test failure on CI is unrelated to this PR and might instead be related to our recent changes to those scripts, or how the test tries to source those scripts for testing (especially as @mokagio Care to take a look to fix that unrelated part (in a separate PR)? |
4b2999c to
13e3bb6
Compare
That auto-downloads the binary from GitHub Release (using the `install.sh` script of the `git-conceal` repo) if it doesn't exist locally, before running `git-conceal unlock` on the current repo to decrypt the secrets
0eddea7 to
9ab2426
Compare
Co-authored-by: Gio Lodi <[email protected]>
Co-authored-by: Gio Lodi <[email protected]>
Co-authored-by: Gio Lodi <[email protected]>
To indicate its name having the `_SECRET_KEY` suffix was chosen purposely so its value would be redacted in the Buildkite logs if it were accidentally leaked.
mokagio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pointed the guinea pig PR to the latest commit on this branch to confirm the latest worked as expected. All green other than the Dangermattic check, which is unrelated
![]()
Closes AINFRA-1606
What?
This PR adds
bin/git-conceal-unlockhelper which takes care of downloadinggit-conceal(using theinstall.shscript from Automattic/git-conceal#3) if it's not installed on the CI machine first, then executinggit-conceal unlock env:${1:-GIT_CONCEAL_SECRET_KEY}to unlock the repo.Testing
This has been tested as part of woocommerce/woocommerce-android#14979
Changelog
CHANGELOG.mdif necessary.